examples: Generate code to its own dedicated dir#2663
Open
ejona86 wants to merge 1 commit into
Open
Conversation
This allows us to delete the directory before re-generating code to avoid stale files from prior builds. This model works well if checking in the code or outputing to OUT_DIR; you'd only change between grpc::include_generated_proto! and grpc::include_proto!.
dfawley
approved these changes
May 29, 2026
|
|
||
| let generated_dir = manifest_dir.join("generated"); | ||
| if generated_dir.exists() { | ||
| std::fs::remove_dir_all(&generated_dir).unwrap(); |
Member
There was a problem hiding this comment.
Nit: this should expect() instead with a message about how it failed trying to clear out your generated directory, so go clean it up by hand (or whatever we want the user to do). Note the recommended style for Result::expect() messages: https://doc.rust-lang.org/std/result/enum.Result.html#recommended-message-style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to delete the directory before re-generating code to avoid stale files from prior builds. This model works well if checking in the code or outputing to OUT_DIR; you'd only change between grpc::include_generated_proto! and grpc::include_proto!.
@dfawley, note that I excluded from this PR the change to input()/include() and such. This PR produces identical codegen output, just at the different location; the other changes change the generated code source.