api: Remove obsolete TODO in EquivalentAddressGroup#toString #12627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@ejona86 @kannanjgithub Thank you for the review on the previous PR. Based on your feedback, I’ve opened this follow-up PR that only removes the now-obsolete TODO in EquivalentAddressGroup#toString() (with a brief explanatory comment). Previous PR: #12600. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
EquivalentAddressGroup is intended to represent a small set of addresses for the same endpoint (e.g., IPv4/IPv6). A long-standing TODO in EquivalentAddressGroup#toString() suggested adding summarization for very large address lists.
During review, maintainers noted that large address lists within a single EquivalentAddressGroup are no longer expected in current designs, and the historical behavior that could create a very large group (e.g., by aggregating many groups into one) has been removed. As a result, the TODO is now obsolete.
Changes
Remove the obsolete TODO comment in EquivalentAddressGroup#toString().
Add a brief explanatory comment capturing why summarization is no longer needed.
Purpose
Avoid leaving stale TODOs that imply work is still required.
Align the codebase with the intended semantics and current behavior of EquivalentAddressGroup.
Note
This change is comment-only and does not alter any runtime behavior or output format.
Fixes #12593