Open
Conversation
This was referenced Nov 11, 2025
sauravzg
force-pushed
the
feat/header-mutations
branch
5 times, most recently
from
328631a to
86d68ac
Compare
This commit introduces configuration objects for the external authorization (ExtAuthz) filter and the gRPC service it uses. These classes provide a structured, immutable representation of the configuration defined in the xDS protobuf messages. The main new classes are: - `ExtAuthzConfig`: Represents the configuration for the `ExtAuthz` filter, including settings for the gRPC service, header mutation rules, and other filter behaviors. - `GrpcServiceConfig`: Represents the configuration for a gRPC service, including the target URI, credentials, and other settings. - `HeaderMutationRulesConfig`: Represents the configuration for header mutation rules. This commit also includes parsers to create these configuration objects from the corresponding protobuf messages, as well as unit tests for the new classes.
xds/src/main/java/io/grpc/xds/internal/headermutations/HeaderMutator.java
Outdated
Show resolved
Hide resolved
sauravzg
force-pushed
the
feat/header-mutations
branch
from
86d68ac to
759130e
Compare
Contributor
Author
|
@kannanjgithub PTAL, if the implementation mutation meets the spec for ext proc. You need to TAL at the last two commits only. |
… the updated requirements
sauravzg
force-pushed
the
feat/header-mutations
branch
from
759130e to
4bfd5e6
Compare
sauravzg
changed the title
sauravzg
force-pushed
the
feat/header-mutations
branch
from
4bfd5e6 to
6961989
Compare
kannanjgithub
requested changes
Mar 13, 2026
Contributor
kannanjgithub
left a comment
kannanjgithub
left a comment
There was a problem hiding this comment.
Sending comments for headermutations.
xds/src/main/java/io/grpc/xds/internal/headermutations/HeaderMutations.java
Outdated
Show resolved
Hide resolved
xds/src/main/java/io/grpc/xds/internal/headermutations/HeaderValueOption.java
Show resolved
Hide resolved
xds/src/main/java/io/grpc/xds/internal/headermutations/HeaderMutator.java
Outdated
Show resolved
Hide resolved
xds/src/main/java/io/grpc/xds/internal/headermutations/HeaderMutationFilter.java
Outdated
Show resolved
Hide resolved
xds/src/main/java/io/grpc/xds/internal/headermutations/HeaderMutationFilter.java
Show resolved
Hide resolved
kannanjgithub
requested changes
Mar 13, 2026
Contributor
kannanjgithub
left a comment
kannanjgithub
left a comment
There was a problem hiding this comment.
Reviewed rest of the PR.
Contributor
Author
|
@kannanjgithub I've resolved or clarified the comments as applicable. PTAL |
sauravzg
force-pushed
the
feat/header-mutations
branch
from
555eebe to
90e5491
Compare
This commit introduces a library for handling header mutations as specified by the xDS protocol. This library provides the core functionality for modifying request and response headers based on a set of rules. The main components of this library are: - `HeaderMutator`: Applies header mutations to `Metadata` objects. - `HeaderMutationFilter`: Filters header mutations based on a set of configurable rules, such as disallowing mutations of system headers. - `HeaderMutations`: A value class that represents the set of mutations to be applied to request and response headers. - `HeaderMutationDisallowedException`: An exception that is thrown when a disallowed header mutation is attempted. This commit also includes comprehensive unit tests for the new library.
sauravzg
force-pushed
the
feat/header-mutations
branch
from
90e5491 to
efb725f
Compare
… headermutations libraries
Contributor
Author
|
@kannanjgithub Addressed the comments. PTAL. |
Contributor
Author
|
/gemini review |
kannanjgithub
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sits on top of #12690, so only the last commit + any fixups need to be reviewed.
This commit introduces a library for handling header mutations as specified by the xDS protocol. This library provides the core functionality for modifying request and response headers based on a set of rules.
The main components of this library are:
HeaderMutator: Applies header mutations toMetadataobjects.HeaderMutationFilter: Filters header mutations based on a set of configurable rules, such as disallowing mutations of system headers.HeaderMutations: A value class that represents the set of mutations to be applied to request and response headers.HeaderMutationDisallowedException: An exception that is thrown when a disallowed header mutation is attempted.This commit also includes comprehensive unit tests for the new library.