refactor: for parameter servers, update existing parameters instead of creating new and deleting old #905
+260
−198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f creating new and deleting old Added forgotten ShortCircuit parameter deletion on study deletion Use DTO for updating LoadFlow parameters Refactored createOrUpdate methods for parameters to better handle the creation of new parameters or update of existing parameters and removed the return in the middle of the method Updated tests to work with updated code
KoloMenek
force-pushed
the
refactor/update_params_instead_of_creation_and_deletion_old
branch
from
2485cbc to
9fb3765
Compare
|
dbraquart
requested changes
Dec 23, 2025
Contributor
dbraquart
left a comment
dbraquart
left a comment
There was a problem hiding this comment.
code : a few remarks
tests : ok for LF (todo for others)
| assertTrue(requests.stream().anyMatch(r -> r.getPath().matches("/v1/cases/" + CASE_UUID))); | ||
| assertTrue(requests.stream().anyMatch(r -> r.getPath().matches("/v1/parameters/" + studyEntity.getVoltageInitParametersUuid()))); | ||
| assertTrue(requests.stream().anyMatch(r -> r.getPath().matches("/v1/parameters/" + studyEntity.getLoadFlowParametersUuid()))); | ||
| assertTrue(requests.stream().anyMatch(r -> r.getPath().matches("/v1/parameters/" + studyEntity.getVoltageInitParametersUuid()))); |
Contributor
There was a problem hiding this comment.
Suggested change
| assertTrue(requests.stream().anyMatch(r -> r.getPath().matches("/v1/parameters/" + studyEntity.getVoltageInitParametersUuid()))); | |
| assertTrue(requests.stream().anyMatch(r -> r.getPath().matches("/v1/parameters/" + studyEntity.getLoadFlowParametersUuid()))); |
LF check has been deleted
| LOGGER.error(String.format("Could not retrieve short circuit parameters with id '%s' from user/profile '%s/%s'. Using default parameters", | ||
| profileSParamId, userId, userProfileinfos.getName()), e); | ||
| // In case of error (ex: wrong/dangling uuid in the profile), fall back to default parameters | ||
| scParametersToUse = scParameters; |
Contributor
There was a problem hiding this comment.
can be removed, same as line 1380
And maybe the comment can be removed too, cause the LOG says everything ?
|
|
||
| if (profileSAParamId != null) { | ||
| try { | ||
| saParametersToUse = securityAnalysisService.getSecurityAnalysisParameters(profileSAParamId); |
Contributor
There was a problem hiding this comment.
I think we need the "keptProvider" here too
| LOGGER.error(String.format("Could not retrieve voltage init parameters with id '%s' from user/profile '%s/%s'. Using default parameters", | ||
| profileVIParamId, userId, userProfileinfos.getName()), e); | ||
| // In case of error (ex: wrong/dangling uuid in the profile), fall back to default parameters | ||
| viParametersToUse = viParameters; |
Contributor
There was a problem hiding this comment.
already done at line 1761
| "Could not retrieve spreadsheet config collection with id '%s' from user/profile '%s/%s'. Using default collection", | ||
| profileSCCId, userId, userProfileinfos.getName()), e); | ||
| // In case of error (ex: wrong/dangling uuid in the profile), fall back to default parameters | ||
| sccToUse = spreadsheetConfigCollection; |
| LOGGER.error(String.format("Could not retrieve dynamic security analysis parameters with id '%s' from user/profile '%s/%s'. Using default parameters", | ||
| profileDSAParamId, userId, userProfileInfos.getName()), e); | ||
| // In case of error (ex: wrong/dangling uuid in the profile), fall back to default parameters | ||
| dsaParametersToUse = dsaParameters; |
| LOGGER.error(String.format("Could not retrieve sensitivity analysis parameters with id '%s' from user/profile '%s/%s'. Using default parameters", | ||
| profileSAParamId, userId, userProfileinfos.getName()), e); | ||
| // In case of error (ex: wrong/dangling uuid in the profile), fall back to default parameters | ||
| saParametersToUse = saParameters; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Added forgotten ShortCircuit parameter deletion on study deletion
Use DTO for updating LoadFlow parameters
Refactored createOrUpdate methods for parameters to better handle the creation of new parameters or update of existing parameters and removed the return in the middle of the method
Updated tests to work with updated code