Skip to content

Conversation

@ayolab
Copy link
Contributor

@ayolab ayolab commented Dec 17, 2025

No description provided.

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
public ResponseEntity<String> getPanels(
@PathVariable("studyUuid") UUID studyUuid,
@PathVariable UUID workspaceId,
@RequestParam(required = false) String ids) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List ?

public ResponseEntity<Void> updateWorkspace(
@PathVariable("studyUuid") UUID studyUuid,
@PathVariable UUID workspaceId,
@Valid @RequestBody String workspaceDto) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why valid ?

this.networkModificationTreeService = networkModificationTreeService;
this.sensitivityAnalysisService = sensitivityAnalysisService;
this.studyConfigService = studyConfigService;
this.workspaceService = workspaceService;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it

@@ -0,0 +1,105 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really need this service ?

notificationService.emitSpreadsheetConfigChanged(studyUuid, configUuid);
}

// Workspace Collection methods
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move theses methods in workspace service

}

// Workspace Collection methods
@Transactional
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readOnly = true

private final StudyConfigService studyConfigService;
private final UserAdminService userAdminService;

public String getWorkspaceCollection(UUID studyUuid, StudyEntity studyEntity) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove studyUuid

return createOrUpdateWorkspaceCollection(studyEntity, workspaceCollection, userId);
}

private String createOrUpdateWorkspaceCollection(StudyEntity studyEntity, String workspaceCollection, String userId) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove userId

@ApiResponse(responseCode = "200", description = "The workspace collection is set and returned"),
@ApiResponse(responseCode = "204", description = "Reset to default (no content returned)")
})
public ResponseEntity<String> setWorkspaceCollection(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really need this endpoint ?

restTemplate.put(studyConfigServerBaseUri + path, httpEntity);
}

public String getPanels(UUID collectionUuid, UUID workspaceId, String ids) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getWorkspacePanels !

ayolab and others added 2 commits December 18, 2025 08:47
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
@ayolab ayolab requested a review from SlimaneAmar December 18, 2025 07:51
@ayolab ayolab changed the title Add workspace collection management Add workspaces config management Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants