-
Notifications
You must be signed in to change notification settings - Fork 2
Add workspaces config management #901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
| public ResponseEntity<String> getPanels( | ||
| @PathVariable("studyUuid") UUID studyUuid, | ||
| @PathVariable UUID workspaceId, | ||
| @RequestParam(required = false) String ids) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
List ?
| public ResponseEntity<Void> updateWorkspace( | ||
| @PathVariable("studyUuid") UUID studyUuid, | ||
| @PathVariable UUID workspaceId, | ||
| @Valid @RequestBody String workspaceDto) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why valid ?
| this.networkModificationTreeService = networkModificationTreeService; | ||
| this.sensitivityAnalysisService = sensitivityAnalysisService; | ||
| this.studyConfigService = studyConfigService; | ||
| this.workspaceService = workspaceService; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove it
| @@ -0,0 +1,105 @@ | |||
| /* | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really need this service ?
| notificationService.emitSpreadsheetConfigChanged(studyUuid, configUuid); | ||
| } | ||
|
|
||
| // Workspace Collection methods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move theses methods in workspace service
| } | ||
|
|
||
| // Workspace Collection methods | ||
| @Transactional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readOnly = true
| private final StudyConfigService studyConfigService; | ||
| private final UserAdminService userAdminService; | ||
|
|
||
| public String getWorkspaceCollection(UUID studyUuid, StudyEntity studyEntity) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove studyUuid
| return createOrUpdateWorkspaceCollection(studyEntity, workspaceCollection, userId); | ||
| } | ||
|
|
||
| private String createOrUpdateWorkspaceCollection(StudyEntity studyEntity, String workspaceCollection, String userId) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove userId
| @ApiResponse(responseCode = "200", description = "The workspace collection is set and returned"), | ||
| @ApiResponse(responseCode = "204", description = "Reset to default (no content returned)") | ||
| }) | ||
| public ResponseEntity<String> setWorkspaceCollection( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really need this endpoint ?
| restTemplate.put(studyConfigServerBaseUri + path, httpEntity); | ||
| } | ||
|
|
||
| public String getPanels(UUID collectionUuid, UUID workspaceId, String ids) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getWorkspacePanels !
No description provided.