implement computation result filters uuid #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etiennehomer
reviewed
Dec 4, 2025
| return restTemplate.exchange(studyConfigServerBaseUri + path, HttpMethod.POST, null, UUID.class).getBody(); | ||
| } | ||
|
|
||
| public UUID getComputationResultFiltersUuidOrElseCreateDefaults(StudyEntity studyEntity) { |
Contributor
There was a problem hiding this comment.
For the spreadsheet, they made the choice to define the default tabs and columns of the spreadsheet for a new study in the back. That's the why the spreadsheet is not empty for a new study.
But here, we don't set default computations filters. It's all empty. So you can delete this endpoint and just manage the null in the front
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
implement computation result filters uuid