Implements operationType support for temporary limits #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meklo
changed the title
added 9 commits
December 15, 2025 10:59
…tion_type_temporary_limits
…tion_type_temporary_limits
…tion_type_temporary_limits
dbraquart
approved these changes
Dec 22, 2025
Contributor
dbraquart
left a comment
dbraquart
left a comment
There was a problem hiding this comment.
code: ok (even if I have an observation)
tests: ok
...in/java/org/gridsuite/modification/modifications/olg/OperationalLimitsGroupModification.java
Show resolved
Hide resolved
Contributor
Mathieu-Deharbe
left a comment
Mathieu-Deharbe
left a comment
There was a problem hiding this comment.
Code ok and test ok. Nice improvement of modifyTemporaryLimit.
Only one change in some code that you moved.
...in/java/org/gridsuite/modification/modifications/olg/OperationalLimitsGroupModification.java
Show resolved
Hide resolved
...in/java/org/gridsuite/modification/modifications/olg/OperationalLimitsGroupModification.java
Outdated
Show resolved
Hide resolved
...in/java/org/gridsuite/modification/modifications/olg/OperationalLimitsGroupModification.java
Outdated
Show resolved
Hide resolved
|
Mathieu-Deharbe
approved these changes
Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Take into account temporary limits new AttributeModification wrapper to only modify fields which are present in the DTO