Refactor global filter to support voltage range #3626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename `getBaseVoltage` to `getBaseVoltageInterval` - Update all relevant components and hooks to use voltage ranges and new method naming Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
…ent and key cleanup Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
|
Mathieu-Deharbe
approved these changes
Jan 7, 2026
| <Checkbox size="small" checked={state.selected} /> | ||
| {option.filterType === FilterType.VOLTAGE_LEVEL ? ( | ||
| <Tooltip title={formatVoltageRange(option)} placement="right"> | ||
| <Typography>{label}</Typography> |
Contributor
There was a problem hiding this comment.
For now the titles are small but wouldn't it be more careful to use a OverflowableText just in case ? Just like the others. After all this part is already partly customizable by the user.
| <ListItemButton selected={state.selected} component="li" {...otherProps}> | ||
| <Checkbox size="small" checked={state.selected} /> | ||
| {option.filterType === FilterType.VOLTAGE_LEVEL ? ( | ||
| <Tooltip title={formatVoltageRange(option)} placement="right"> |
Contributor
There was a problem hiding this comment.
The last time I added a tooltip Stéphane asked for an arrow on it. I like it :
Suggested change
| <Tooltip title={formatVoltageRange(option)} placement="right"> | |
| <Tooltip title={formatVoltageRange(option)} placement="right" arrow> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request refactors the global filter to support voltage ranges. Also, the method
getBaseVoltageis renamed togetBaseVoltageInterval.