add transpose and adjoint#41
Open
PetrKryslUCSD wants to merge 1 commit into
Open
Conversation
JordiManyer
reviewed
May 19, 2026
Member
JordiManyer
left a comment
JordiManyer
left a comment
There was a problem hiding this comment.
Hi @PetrKryslUCSD, sorry for the delay. For some reason github does not put these PRs in my inbox.
I've made some minor comments, I think just typos left out from development. Could you also pull from master?
Cheers!
|
|
||
| """ | ||
| colvals(S::SparseMatrixCSR{Bi}) where {Bi} | ||
| colvals(S::SparseMatrixCSR) |
Member
There was a problem hiding this comment.
Is there a reason to split the docstring from the function? I think this might just be a mistake.
Member
There was a problem hiding this comment.
Also, is there a reason you changed the docstring? Bi does get used within the documentation of the function itself, so it might be better if it stays there?
| Return the range of indices to the structural nonzero values of a | ||
| sparse matrix row. The returned range of indices is always 1-based even for `Bi != 1`. | ||
| """ | ||
| nzrange(S::SparseMatrixCSR{Bi}, row::Integer) where {Bi} = S.rowptr[row]+getoffset(S):S.rowptr[row+1]-Bi |
Member
There was a problem hiding this comment.
I think this also got indented by mistake? Both function and docstring look weird.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.