Re-implement http client using fetch #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fetch needs `duplex: half` when setting a stream request body. https://developer.chrome.com/docs/capabilities/web-apis/fetch-streaming-requests#half_duplex This also adds an error case to the legacy streams api when configuring a request with `withStreamBody`
andrewMacmurray
force-pushed
the
http-client-fetch
branch
from
6fc9838 to
3da0bc0
Compare
Member
|
Thank you! 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-implements the http client using node's builtin
fetchapi. We did this is for a few reasons:Streaming requests and responses
The
fetchapi natively supports streaming request and response bodies, so it's pretty trivial to implement:withStreamBodyexpectStreamThis means we can work with native
gren/core/Streams when making http requests 🎉 .Legacy streaming api
For now we've left the custom stream api so we don't have to make a breaking change, and we'll aim to remove this around the December release.
Follow up work
After this change when a stream error occurs during an http request an
UnknownErrorwill be returned.Ideally we'd like to get a structured error for this case, but we haven't arrived yet at the right design for this (can we only include this error case for streaming requests so non streaming request don't need to handle it?).