json: fix potential overflow #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code:
```cpp
while(!EMPTY_STRING(input) && stream.push(*index) != json::reader::REJECTED)
{
index++;
}
```
Runs into an issue because `EMPTY_STRING(input)` is used to check for
null-pointer ending, but `input` is never incremented during the loop.
As such, an overflow will happen when `index` has incremented beyond
it's buffer and `*index` is run. This triggers an overflow on the
`input` buffer as `index` is declared as:
`const char *index = json::parsing::tlws(input);`
Instead of checking for an empty string on `input` we should check it on
`index`.
Signed-off-by: David Korczynski <david@adalogics.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code:
while(!EMPTY_STRING(input) && stream.push(*index) != json::reader::REJECTED) { index++; }Runs into an issue because
EMPTY_STRING(input)is used to check for null-pointer ending, butinputis never incremented during the loop. As such, an overflow will happen whenindexhas incremented beyond it's buffer and*indexis run. This triggers an overflow on theinputbuffer asindexis declared as:const char *index = json::parsing::tlws(input);Instead of checking for an empty string on
inputwe should check it onindex.