Skip to content

Conversation

@ArneTR
Copy link
Member

@ArneTR ArneTR commented Dec 9, 2025

This PR aims to remove a key we introduced a while ago to the service definition in the compose file:

  • type

Currently there never was and there currently is no use for this key and thus it shall be removed as it poses rather a compatibility risk than any gain.

In case it can get reintroduced.

This PR will stay open for one month as RFC. If no complaings happen it will be removed.

Greptile Overview

Greptile Summary

This PR removes the legacy type field from service definitions in usage scenario YAML files. The field was defined in the schema from the beginning but was never actually used by the system. The only valid value was container, which provided no functional benefit.

Key changes:

  • Removed valid_service_types() validation method from lib/schema_checker.py:57-62
  • Removed Optional('type'): Use(self.valid_service_types) from the service schema in lib/schema_checker.py:102
  • Removed type: container lines from 57 test and example usage scenario files

Assessment:
The removal is clean and complete. No runtime code references the type field, and the schema validation properly rejects it as an unsupported key after this change. Since the field was never used functionally, this is a low-risk cleanup that simplifies the schema.

@ArneTR
Copy link
Member Author

ArneTR commented Dec 9, 2025

@greptileai

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

57 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants