Removed legacy custom key type #1481
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to remove a key we introduced a while ago to the service definition in the compose file:
typeCurrently there never was and there currently is no use for this key and thus it shall be removed as it poses rather a compatibility risk than any gain.
In case it can get reintroduced.
This PR will stay open for one month as RFC. If no complaings happen it will be removed.
Greptile Overview
Greptile Summary
This PR removes the legacy
typefield from service definitions in usage scenario YAML files. The field was defined in the schema from the beginning but was never actually used by the system. The only valid value wascontainer, which provided no functional benefit.Key changes:
valid_service_types()validation method fromlib/schema_checker.py:57-62Optional('type'): Use(self.valid_service_types)from the service schema inlib/schema_checker.py:102type: containerlines from 57 test and example usage scenario filesAssessment:
The removal is clean and complete. No runtime code references the
typefield, and the schema validation properly rejects it as an unsupported key after this change. Since the field was never used functionally, this is a low-risk cleanup that simplifies the schema.