fix : exclusion des variables dont le parent est une méthode abstract#187
Open
riana-ysuf wants to merge 3 commits into
Open
fix : exclusion des variables dont le parent est une méthode abstract#187riana-ysuf wants to merge 3 commits into
riana-ysuf wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a false-positive in rule GCI82 (MakeNonReassignedVariablesConstants): parameters of abstract methods (including interface methods without a body) cannot be declared final in a meaningful way and should not be reported. The PR also removes debug logging code that had been left in the check, and adds integration test cases for functional interfaces and interfaces with abstract, default, and static methods.
Changes:
- Add
isParameterOfAbstractMethodguard invisitNodeto skip variables whose parent is a method with no body. - Remove leftover
Logger/Loggersdebug code and the buggygetVariableNameForLoggerhelper (which had an inverted null check). - Add integration test cases for a
@FunctionalInterfaceand an interface mixing abstract, default, and static methods; add a CHANGELOG entry.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/java/org/greencodeinitiative/creedengo/java/checks/MakeNonReassignedVariablesConstants.java | Adds abstract-method-parameter exclusion and removes debug logging code. |
| src/it/test-projects/.../GCI82/MakeNonReassignedVariablesConstants.java | Adds test cases covering functional interface and interface methods (abstract/default/static). |
| CHANGELOG.md | Documents the GCI82 false-detection fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exclusion des variables dont le parent est une méthode abstract + cas de test