lf_wifi_capacity_test.py: compatibility changes for WebGUI #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
smileyrekiere
left a comment
smileyrekiere
left a comment
There was a problem hiding this comment.
Why would you not what the file name in the logging
| self.create_test_config(self.config_name, "Wifi-Capacity-", add_port) | ||
| idx += 1 | ||
|
|
||
| self.apply_cfg_options(cfg_options, self.enables, self.disables, self.raw_lines, self.raw_lines_file) |
Collaborator
There was a problem hiding this comment.
Isn't this line necessary ? self.apply_cfg_options? we do use self.raw_lines and raw_lines_files ,
Collaborator
Author
There was a problem hiding this comment.
Not removed, just moved:
926f503#diff-f9ff5115e724be6dab7cfc51d0a81a5f0b28a9ea5e9cb0b34cb5cf053e8fb88bR241
Collaborator
Author
There was a problem hiding this comment.
The file name is left out of the logging as the --logger_no_file flag is passed from WebGUI. It was less of a decision on my end, and more of a interface change to make it more compatible.
What it says on the tin, makes the WiFi
Capacity Test py-json script work from
WebGUI.
Patch at customer request.
CLI to run:
./lf_wifi_capacity_test.py --mgr localhost \
--port 8080 \
--instance_name wificap-webgui-inst \
--local_lf_report_dir /home/lanforge/Desktop \
--raw_lines_file /home/lanforge/wificap.txt
CLI issued by WebGUI:
./lf_wifi_capacity_test.py --mgr 192.168.102.229 \
--logger_no_file \
--pull_report \
--raw_line rpt_path:/home/lanforge \
--instance_name 'WBGUIWCAPTEST' \
--raw_lines_file '/home/lanforge/local/interop-webGUI/media/uploads/chamber_tests/WBGUIWCAPTEST/wificap.txt'
Signed-off-by: John-Paul M. Powers <jpmp@candelatech.com>
jpmprog
force-pushed
the
0001-scripts-lf_wifi_capacity_test.py-WebGUI-fix.patch
branch
from
4d84def to
5b1ab8c
Compare
smileyrekiere
approved these changes
Jan 12, 2026
jpmprog
deleted the
0001-scripts-lf_wifi_capacity_test.py-WebGUI-fix.patch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it says on the tin, makes the WiFi
Capacity Test py-json script work from
WebGUI.
Patch at customer request.