-
Notifications
You must be signed in to change notification settings - Fork 387
made web-app-theme rails 3.1 compatible #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Excellent! when would this be merged? |
Fixed test directory references
|
@nathanvda, can you please rebase it to 0.7.0. Your fork does not contain Activo 2 theme and it will also be easier for @pilu to pull. I've done this for ourselves in our fork, but I'm sure others would love to point your Gemfile's to your fork until it gets pulled into an official version. |
… up correctly in rails3.1 (without having to edit the stylesheets).
|
I had some troubles getting the default (activo-2) working correctly. I got it to work (without needing to edit any stylesheet) if i copied the images and fonts (under stylesheets) to |
|
The 'problem' is that the default JS and CSS assets are combined into application.js and application.css in Rails 3.1, so any relative paths will be relative to that, even if they were originally pulled in by Sprockets from a subdirectory by |
I made sure web-app-theme works with rails 3.0 and rails 3.1. Furthermore I fixed the specs so the generators are tested more. I did not check the cucumber features.