fix: make react block renders in sync with canvas #222
+34
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a block is dragged, react-rendered block is slightly late to the actual state of the block position, it is not in-sync and while dragging appears a jelly effect.
You can see this effect by opening storybook and set 10000 blocks. It appears clearly enough when you drag a block with a link.
Why it happens
Current code uses
useBlockStateand inside of ituseSignal, which updates state by usingsetState. React may postpone the render after setState, so this is why it may not be in-sync with the actual state.Solution
Instead of calling setState and waiting for React to render we subscribe directly to
state.$geometryand mutate styles synchronously.