Use Object.create(null) over {} to avoid prototype issues#4634
Merged
Use Object.create(null) over {} to avoid prototype issues#4634
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
yaacovCR
reviewed
Mar 25, 2026
yaacovCR
reviewed
Mar 25, 2026
yaacovCR
previously requested changes
Apr 16, 2026
yaacovCR
added
the
PR: breaking change 💥
yaacovCR
force-pushed
the
obj-create-null-17
branch
from
315e52e to
3ee6c94
Compare
yaacovCR
pushed a commit
that referenced
this pull request
Apr 18, 2026
completes conversion of execution values to use of prototype-less objects begun in #4634 = adds tests for the new behavior = fixes out-of-date comments = small type-change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-port of #4631. Description from #4631 on v16
But this PR skips that latter portion, return
objrather than{ ...obj }, a BREAKING CHANGE for v17 that improves performance, compareobj-create-null-17vsrestore-prototype