Remove redundant @ prefix checks already enforced by JSON schema#21
Open
magicmark wants to merge 5 commits intographql:mainfrom
Open
Remove redundant @ prefix checks already enforced by JSON schema#21magicmark wants to merge 5 commits intographql:mainfrom
magicmark wants to merge 5 commits intographql:mainfrom
Conversation
The `startsWith("@")` checks for `githubUsername` and `sponsor` in
validate-structure.js duplicate the `"pattern": "^@"` constraint already
defined in metadata.schema.json. The schema validation (via ajv) runs
first and catches these, making the manual checks dead code.
Also update CONTRIBUTING.md to reflect that CODEOWNERS is now
automatically synced from metadata.yml (via sync-codeowners workflow).
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This is handled automatically by the sync-codeowners workflow. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
startsWith("@")validation - this is already enforced inmetadata.schema.jsonCONTRIBUTING.mdto reflect thatCODEOWNERSis now automatically generated