add @mock spec#10
Open
magicmark wants to merge 37 commits intographql:mainfrom
Open
Conversation
rebello95
reviewed
Mar 13, 2026
rebello95
left a comment
rebello95
left a comment
There was a problem hiding this comment.
Left some comments documenting our discussion earlier today, as well as a few other things I noticed 😄 Thanks for the hard work here!
rebello95
reviewed
Apr 2, 2026
rebello95
left a comment
rebello95
left a comment
There was a problem hiding this comment.
Great work on this! I read through the whole thing and mostly have small nits/comments. Overall this is coming together!
|
|
||
| The values generated for leaf nodes do not matter and do not need to be | ||
| preserved or included in the description - unless otherwise specified by the | ||
| user. |
There was a problem hiding this comment.
Would suggest mentioning that aliases should be used in __path__ when present
|
|
||
| ## Schema | ||
|
|
||
| Look for the GraphQL schema in <repo_root>/schema.graphql to understand what |
There was a problem hiding this comment.
Suggested change
| Look for the GraphQL schema in <repo_root>/schema.graphql to understand what | |
| Look for the GraphQL schema in <repo_root>/schema.graphqls to understand what |
May want to consider removing the filename here since it's implementation-specific
Co-authored-by: Michael Rebello <me@michaelrebello.com>
Co-authored-by: Michael Rebello <me@michaelrebello.com>
Co-authored-by: Michael Rebello <me@michaelrebello.com>
Co-authored-by: Michael Rebello <me@michaelrebello.com>
Co-authored-by: Michael Rebello <me@michaelrebello.com>
Co-authored-by: Michael Rebello <me@michaelrebello.com>
Co-authored-by: Michael Rebello <me@michaelrebello.com>
Co-authored-by: Michael Rebello <me@michaelrebello.com>
Co-authored-by: Michael Rebello <me@michaelrebello.com>
Co-authored-by: Michael Rebello <me@michaelrebello.com>
Co-authored-by: Michael Rebello <me@michaelrebello.com>
Co-authored-by: Michael Rebello <me@michaelrebello.com>
Specify list mock semantics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see graphql/ai-wg#79
Prior art! https://medium.com/airbnb-engineering/graphql-data-mocking-at-scale-with-llms-and-generatemock-30b380f12bd6