-
Notifications
You must be signed in to change notification settings - Fork 187
Fix DeprecationWarning in test_requests_batch online tests #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DeprecationWarning in test_requests_batch online tests #582
Conversation
|
Sorry, could you please explain what you are trying to fix here? I don't see any |
|
@leszekhanusz When running These warnings appear at the end of the test output in the "warnings summary" section. Environment:
This PR aims to update the tests to use the new |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #582 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 38 40 +2
Lines 2908 3311 +403
==========================================
+ Hits 2908 3311 +403 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Okay, I can now reproduce the warnings, but only if I activate the online tests with I don't understand how you get them without using the Anyway the problem is only one line, I don't see why you're introducing all those other changes and new tests, I suspect greedy llm output. could simply be replaced by: Please modify your PR to only those two lines. Please note that the gql method is NOT deprecated. |
7da4e00 to
404655d
Compare
|
Thank you for the detailed feedback. |
|
Thanks. |
Replace deprecatedgql()withGraphQLRequestin test_requests_batch.pyUse
query.variable_valuesinstead of deprecatedvariable_valuesargument insession.execute().