Allow pinning altair-static package version via AltairOptions#1211
Open
ben-schmidt wants to merge 1 commit intographql-dotnet:masterfrom
Open
Allow pinning altair-static package version via AltairOptions#1211ben-schmidt wants to merge 1 commit intographql-dotnet:masterfrom
ben-schmidt wants to merge 1 commit intographql-dotnet:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability for users of graphql-dotnet to explicitly pin the version of altair-static used by the Altair UI integration.
Previously, the middleware always relied on loading the latest version of Altair from a CDN. While convenient, this caused a number of issues when upstream Altair releases introduced breaking changes or unexpected behavior—changes that were immediately reflected in running applications without any modification by the user.
Why This Matters
Relying on a moving/latest CDN target can result in:
By enabling version pinning, applications get:
What This PR Does