store: Skip chains on shards with no connection pool#6441
Open
dimitrovmaksim wants to merge 1 commit intographprotocol:masterfrom
Open
store: Skip chains on shards with no connection pool#6441dimitrovmaksim wants to merge 1 commit intographprotocol:masterfrom
dimitrovmaksim wants to merge 1 commit intographprotocol:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6195
Addresses a startup failure when
pool_size = 0for a chain's shard. Two cases are handled:config.tomland it's shard haspool_size = 0— treated as a misconfiguration; graph-node panics with an actionable message.Note: if the configured shard differs from the shard recorded in the DB, the check is performed against the DB shard, since the config is ignored in that case. (maybe we should panic here as well)
config.tomlbut present in the DB — graph-node normally builds a chain store for such chains. Ifpool_size = 0for the chain'sshard, it is now skipped with a warning instead of panicking.