perf: remove blocking calls from POI queries #6300
Open
+34
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove synchronous `block_on` call in `resolve_proof_of_indexing` which was blocking tokio worker threads while waiting for database queries. Before this change, each POI query blocked an entire tokio worker thread. After this change, POI queries properly yield to the async runtime while waiting for database I/O, allowing the connection pool to be fully utilized. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Change the publicProofsOfIndexing resolver to process all POI requests in parallel using `future::join_all` instead of sequentially in a for loop. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Two optimizations for POI query handling in the index-node resolver:
Make
resolve_proof_of_indexingasync - Removes synchronousblock_oncall that was blocking tokio worker threads while waiting for database queries. POI queries now properly yield to the async runtime.Parallelize
publicProofsOfIndexingrequests - Changes sequential for-loop tofuture::join_allfor concurrent execution of batch POI requests.Changes
server/index-node/src/resolver.rsresolve_proof_of_indexing:fn→async fn,block_on(fut)→fut.awaitresolve_public_proofs_of_indexing: sequential loop →future::join_allfutureimport fromgraph::futures03