Open
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Author
|
@darealshinji I think all changes for cl.exe should be in another PR. This PR doesn't change behavior for cl.exe but only for clang-cl.exe. |
Owner
|
See the other PR for why I'm unsure about this one. |
Without this PR it definitely doesn't work on clang-cl: |
Author
What do yo mean? PR #66 ? Do you want to use __declspec(align(INCBIN_ALIGNMENT)) in clang-cl.exe like in cl.exe instead of __attribute__((aligned(INCBIN_ALIGNMENT)))? clang-cl.exe supports both syntaxes so I think there is no difference https://godbolt.org/z/1v9jzvovq . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with clang-cl.exe on amd64 and x86.