test: fix failing example tests#124
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Moves the example tests from the example/ subdirectory into the package root so they are detected and executed by go test, and renames the example functions to follow Go's ExampleX_Y convention so they appear in godoc under NewBatchedLoader.
Changes:
- Relocates
ttl_cache/go-cache example intoexample_go_cache_test.goat repo root underpackage dataloader_test. - Renames cache adapter types and example functions (e.g.
ExampleGolangLRU→ExampleNewBatchedLoader_golangLRU) to avoid collisions and conform to godoc example naming. - Updates README to reflect the new example location.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates pointer to example location. |
| example/ttl_cache/go_cache_test.go | Deletes the old example file (moved to repo root). |
| example_no_cache_test.go | Repackages under dataloader_test; minor comment cleanup. |
| example_golang_lru_test.go | Repackages under dataloader_test, renames adapter type and example function. |
| example_go_cache_test.go | New file containing the relocated go-cache example with renamed adapter and example function. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.