feat: Correct some of the wasm gc v124 bindings#261
Open
spotandjake wants to merge 10 commits intooscar/gcfrom
Open
feat: Correct some of the wasm gc v124 bindings#261spotandjake wants to merge 10 commits intooscar/gcfrom
spotandjake wants to merge 10 commits intooscar/gcfrom
Conversation
Member
Author
|
This pr technically closes #240 but we probably don't want to close that issue until merging the main pr. |
spotandjake
added
the
Api
Member
Author
|
The pr I put up to binaryen It should be released in Binaryen V126. |
This just fixes some small todo's by using the js api where possible
spotandjake
force-pushed
the
spotandjake/gc-additions
branch
from
bce8908 to
bf67f11
Compare
While working on #265 I noticed that I was getting errors on `caml_binaryen_add_custom_section` as `caml_array_of_string` was deprecated for `caml_uint8_array_of_string` this updates that. The reason this doesn't appear for us is because of our test suite never calls this function.
spotandjake
force-pushed
the
spotandjake/gc-additions
branch
from
bf67f11 to
1eaa67d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This corrects most of the
v124wasm gc changes.Notes:
callRefI can probably make a pr for those, though iirc @ospencer said they had the work done already.typparameter correctly onbr_on_null, given that two of the cases do not take thetypparameter in the js api.The js test are going to fail due to the callRef bindings.