fix: sdkusage now checking plugin's version age for warnings and errors #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to 📬 Triage
in Plugins Platform / Grafana Community
academo
commented
Jan 13, 2026
| return nil, nil | ||
| } | ||
|
|
||
| // check if go sdk was replaced before doing any version checks |
Collaborator
Author
There was a problem hiding this comment.
this is the same code, just moving it up so we check for a sdk replacement before we do sdk age checks.
academo
commented
Jan 13, 2026
| } | ||
|
|
||
| func TestValidGoMod(t *testing.T) { | ||
| httpmock.Activate() |
Collaborator
Author
There was a problem hiding this comment.
tests changes focus around putting the "correct" dates for tests
academo
moved this from 📬 Triage
to 🔬 In review
in Plugins Platform / Grafana Community
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation was incorrectly checking the age of the latest go-sdk release instead of the age of the version the plugin is using.
This change makes it so the validator checks the version of the grafana go sdk the plugin is using