Skip to content

fix!: prevent unsigned plugins from reaching dev, allow grafana-plugins-platform-bot[bot] to sign plugins#708

Open
manderson-dev wants to merge 5 commits into
mainfrom
fix/dev-must-be-verified
Open

fix!: prevent unsigned plugins from reaching dev, allow grafana-plugins-platform-bot[bot] to sign plugins#708
manderson-dev wants to merge 5 commits into
mainfrom
fix/dev-must-be-verified

Conversation

@manderson-dev
Copy link
Copy Markdown

This pull request introduces a new workflow input, allow-unsigned-in-dev, to both the CI and CD GitHub Actions workflows. This input serves as an "escape hatch" to optionally restore the previous behavior of allowing unsigned plugin builds in untrusted development contexts, which is now disabled by default. The changes also update the logic for when unsigned builds are permitted and add support for a new GitHub Actions actor. The most important changes are as follows:

Workflow Input and Logic Updates:

  • Added a new boolean input allow-unsigned-in-dev to .github/workflows/ci.yml and .github/workflows/cd.yml, allowing maintainers to opt-in to the old behavior of permitting unsigned dev builds in untrusted contexts. This is now false by default, so untrusted dev builds will hard-fail unless explicitly enabled. [1] [2]
  • Updated the logic for the allow-unsigned parameter in both workflows to only allow unsigned builds in untrusted dev environments if allow-unsigned-in-dev is set to true. This further restricts when unsigned builds are permitted. [1] [2] [3]

Documentation and Comments:

  • Added and updated descriptions and comments in the workflow files to clarify the behavior and intent of the new allow-unsigned-in-dev input, including its default value and usage scenarios. [1] [2] [3]

CI Workflow Actor Update:

  • Added github-merge-queue[bot] to the list of trusted actors in the CI workflow, recognizing it as a maintainer-approved actor for post-merge pushes.

Test Workflow Support:

  • Updated the test workflow code (tests/act/internal/workflow/ci/ci.go) to include support for the new AllowUnsignedInDev input, ensuring test coverage for this new workflow parameter. [1] [2]

…ult, but setting the option for it to be overriden. Also granting the merge queue bot permisisons to sign plugins.
@cla-assistant
Copy link
Copy Markdown

cla-assistant Bot commented May 4, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@cla-assistant
Copy link
Copy Markdown

cla-assistant Bot commented May 4, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@grafana-plugins-platform-bot grafana-plugins-platform-bot Bot moved this from 📬 Triage to 🔬 In review in Grafana Catalog Team May 4, 2026
leventebalogh
leventebalogh previously approved these changes May 5, 2026
Copy link
Copy Markdown

@leventebalogh leventebalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one minor comment, but generally LGTM 👍

(Nit: the PR title mentions grafana-plugins-platform-bot[bot], not the github-merge-queue[bot].)

RunTruffleHog *bool

AllowUnsigned *bool
AllowUnsignedInDev *bool
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might makes sense to add a test case covering the new input.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a test!

leventebalogh
leventebalogh previously approved these changes May 6, 2026
@xnyo xnyo changed the title fix: Prevent unsigned plugins from reaching dev, allow grafana-plugins-platform-bot[bot] to sign plugins fix!: prevent unsigned plugins from reaching dev, allow grafana-plugins-platform-bot[bot] to sign plugins May 6, 2026
xnyo
xnyo previously approved these changes May 6, 2026
Copy link
Copy Markdown
Member

@xnyo xnyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, just a couple of small suggestions.

Note: I have also renamed the PR from fix: to fix!: for flagging this as a breaking change and trigger a new major release via release-please

Comment thread .github/workflows/cd.yml Outdated
Comment thread .github/workflows/ci.yml
Co-authored-by: Giuseppe Guerra <giuseppe.guerra@grafana.com>
@manderson-dev manderson-dev dismissed stale reviews from xnyo and leventebalogh via ab00067 May 6, 2026 12:41
xnyo
xnyo previously approved these changes May 7, 2026
Copy link
Copy Markdown
Member

@xnyo xnyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Co-authored-by: Giuseppe Guerra <giuseppe.guerra@grafana.com>
@manderson-dev
Copy link
Copy Markdown
Author

Sorry i let this sit some, got busy with other things. Since its end of day Friday, I'll plan to merge this on Monday, i set a reminder. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔬 In review

Development

Successfully merging this pull request may close these issues.

3 participants