fix!: prevent unsigned plugins from reaching dev, allow grafana-plugins-platform-bot[bot] to sign plugins#708
fix!: prevent unsigned plugins from reaching dev, allow grafana-plugins-platform-bot[bot] to sign plugins#708manderson-dev wants to merge 5 commits into
Conversation
…ult, but setting the option for it to be overriden. Also granting the merge queue bot permisisons to sign plugins.
|
|
1 similar comment
|
|
| RunTruffleHog *bool | ||
|
|
||
| AllowUnsigned *bool | ||
| AllowUnsignedInDev *bool |
There was a problem hiding this comment.
Might makes sense to add a test case covering the new input.
xnyo
left a comment
There was a problem hiding this comment.
Code LGTM, just a couple of small suggestions.
Note: I have also renamed the PR from fix: to fix!: for flagging this as a breaking change and trigger a new major release via release-please
Co-authored-by: Giuseppe Guerra <giuseppe.guerra@grafana.com>
Co-authored-by: Giuseppe Guerra <giuseppe.guerra@grafana.com>
|
Sorry i let this sit some, got busy with other things. Since its end of day Friday, I'll plan to merge this on Monday, i set a reminder. :) |
This pull request introduces a new workflow input,
allow-unsigned-in-dev, to both the CI and CD GitHub Actions workflows. This input serves as an "escape hatch" to optionally restore the previous behavior of allowing unsigned plugin builds in untrusted development contexts, which is now disabled by default. The changes also update the logic for when unsigned builds are permitted and add support for a new GitHub Actions actor. The most important changes are as follows:Workflow Input and Logic Updates:
allow-unsigned-in-devto.github/workflows/ci.ymland.github/workflows/cd.yml, allowing maintainers to opt-in to the old behavior of permitting unsigned dev builds in untrusted contexts. This is now false by default, so untrusted dev builds will hard-fail unless explicitly enabled. [1] [2]allow-unsignedparameter in both workflows to only allow unsigned builds in untrusteddevenvironments ifallow-unsigned-in-devis set to true. This further restricts when unsigned builds are permitted. [1] [2] [3]Documentation and Comments:
allow-unsigned-in-devinput, including its default value and usage scenarios. [1] [2] [3]CI Workflow Actor Update:
github-merge-queue[bot]to the list of trusted actors in the CI workflow, recognizing it as a maintainer-approved actor for post-merge pushes.Test Workflow Support:
tests/act/internal/workflow/ci/ci.go) to include support for the newAllowUnsignedInDevinput, ensuring test coverage for this new workflow parameter. [1] [2]