feat: add generic playwright-cloud reusable workflow for Cloud E2E tests#602
Closed
feat: add generic playwright-cloud reusable workflow for Cloud E2E tests#602
playwright-cloud reusable workflow for Cloud E2E tests#602Conversation
playwright-cloud reusable workflow for Cloud E2E testsplaywright-cloud reusable workflow for Cloud E2E tests
This comment has been minimized.
This comment has been minimized.
142b17c to
e4d9d22
Compare
da42848 to
f3cc444
Compare
2fbd478 to
d4b4d23
Compare
Author
|
This is awaiting https://github.com/grafana/deployment_tools/pull/519206, and once it's merged, it'll be ready for review. |
096913b to
2581346
Compare
2581346 to
979aa67
Compare
a329f85 to
2be5e6c
Compare
2be5e6c to
a7b3e92
Compare
Author
|
Closing in favour of https://github.com/grafana/data-sources/pull/1095. I think, as written, these plugins are not generic enough to add to this repo. We'll add these to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
.github/workflows/playwright-cloud.yml, a reusable workflow for running Playwright E2E tests against a shared Grafana Cloud instance via Grafana Bench. The workflow is generic and can be called from any datasource plugin repo.Data source-specific Vault secrets, Grafana URL, Bench commands, Bench version, and service version are all configurable via inputs. Act tests are included to validate the happy path and the fork-skip condition.
Usage in a calling repo
Create a workflow file (e.g.
.github/workflows/cron.yml) in your datasource repo:The keys on the left side of each
=become environment variables inside the Bench container and are forwarded to the Playwright process. The values on the right are Vault paths in the formatvault-secret-name:field.If your datasource uses Private Data Source Connect, pass the PDC network name via the
pdc-network-nameinput.Deploying the plugin to the Cloud E2E instance
To deploy a plugin to the
datasourcese2einstance on push to main, usecd.ymldirectly: