chore(workflows): make release-please update major and major.minor tags#89
Conversation
| * **deps:** bump actions/create-github-app-token from 1 to 2 ([#79](https://github.com/grafana/github-api-commit-action/issues/79)) ([412b51b](https://github.com/grafana/github-api-commit-action/commit/412b51bdf2e89caaf37e5b53b8fbc8a4c1c1c412)) | ||
| * **deps:** bump grafana/github-api-commit-action from 0.3.0 to 0.3.1 ([#65](https://github.com/grafana/github-api-commit-action/issues/65)) ([cdc46bd](https://github.com/grafana/github-api-commit-action/commit/cdc46bd6d01c95fecdf1cf2acb3106478518d17e)) | ||
| * trigger tests via workflow call, dispatch or push to main ([#75](https://github.com/grafana/github-api-commit-action/issues/75)) ([f72ba3b](https://github.com/grafana/github-api-commit-action/commit/f72ba3ba7d3a7def86ad1d8b5e7706912494e4c1)) | ||
| * update changelog [bot] ([#69](https://github.com/grafana/github-api-commit-action/issues/69)) ([baa0805](https://github.com/grafana/github-api-commit-action/commit/baa08050b07ba580a957460f3a47571b532104d1)) |
There was a problem hiding this comment.
clearing out some cruft
There was a problem hiding this comment.
Pull Request Overview
This PR streamlines the release workflow by removing redundant changelog bot updates and enhancing the release-please workflow to update major and major.minor tags.
- Removed outdated changelog bot entries from CHANGELOG.md
- Updated the release-please workflow to add steps for tagging major and minor releases and update the README
Reviewed Changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| CHANGELOG.md | Removed repeated changelog bot updates |
| .github/workflows/release-please.yml | Added permission configurations, outputs, and steps to handle tag updates |
Files not reviewed (3)
- .github/workflows/release-on-tag.yml: Language not supported
- .github/workflows/update-major-release-tag.yml: Language not supported
- docs/README.tmpl: Language not supported
| git remote add gh-token "https://${{ secrets.GITHUB_TOKEN }}@github.com/googleapis/release-please-action.git" | ||
|
|
||
| # Delete old major and minor tag | ||
| git tag -d v${{ steps.release.outputs.major }} || true |
There was a problem hiding this comment.
The workflow references 'steps.release.outputs.major' and 'steps.release.outputs.minor' in later steps, but these outputs are not defined in the outputs block. Define these outputs or update the references accordingly.
…elease-on-tag Conflicts: .github/workflows/release-on-tag.yml
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the release-please workflow to correctly manage major and minor version tags and streamlines the changelog updates. Key changes include removing duplicate changelog update lines from CHANGELOG.md, adding steps to delete and recreate major and minor tags in the release-please workflow, and including a new readme update job that leverages the new tag outputs.
Reviewed Changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| CHANGELOG.md | Removed duplicate changelog update entries |
| .github/workflows/release-please.yml | Enhanced tag creation logic and added a readme update step |
Files not reviewed (3)
- .github/workflows/release-on-tag.yml: Language not supported
- .github/workflows/update-major-release-tag.yml: Language not supported
- docs/README.tmpl: Language not supported
| run: | | ||
| git config user.name github-actions[bot] | ||
| git config user.email 41898282+github-actions[bot]@users.noreply.github.com | ||
| git remote add gh-token "https://${{ secrets.GITHUB_TOKEN }}@github.com/googleapis/release-please-action.git" |
There was a problem hiding this comment.
The added remote 'gh-token' is not used in subsequent git push commands (which target 'origin'). Consider either removing this remote addition or updating the push commands to utilize 'gh-token' if that is the intended behavior.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
abannachGrafana
dismissed stale reviews from Johngeorgesample and xiyu95
via
c03f387
No description provided.