refactor: add internal Date adapter boundary#2974
Draft
gpbl wants to merge 1 commit into
Draft
Conversation
|
e2c05cc to
b659487
Compare
b659487 to
24c4927
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DayPicker remains intentionally Date-based today, but the planned Temporal work needs an internal boundary between calendar logic and the concrete date implementation. Native Date assumptions are currently spread through calendar state, stable keys, comparisons, selection, and matcher logic. This change introduces that boundary while keeping
react-day-pickerinstantiated with Date only.What Changed
Behavior Guarantees
react-day-pickerstill instantiates the internals with native Date only.DateLibremains the source of truth for existing math, formatting, equality, and override behavior.TZDateremainsDate-compatible and time keys remain equivalent to getTime().