Support extracting standalone IAMF from MP4#60
Open
aureliendavid wants to merge 4 commits into
Open
Conversation
…o reflect additional properties. (gpac#3567) - `reframers.sh`, `reframer-iamf-ext-rewrite.hash`: New test for standalone IAMF extraction. - `mp4box-io-audio_opus.iamf`: Includes superior RFC6381 identifier: ```diff - Codec: NULL + Codec: iamf.001.001.opus ``` - `mp4box-mux-add-iamf`: Includes superior RFC6381 identifier, clean up buggy IA Sequence Header (0xf8) reporting "configurationVersion 248": ```diff - [IAMF] Unknown configurationVersion 248 - PID 2 ID 2 audio ... codec AOM IAMF (Immersive Audio Model and Formats) + PID 2 ID 2 audio ... codec iamf.001.001.opus AOM IAMF (Immersive Audio Model and Formats) ```
Add test for standalone IAMF extraction. Update IAMF inspect hashes t…
- Break out test, to help test round-trip reframing from standalone IAMF -> IAMF in MP4 -> back to standalone IAMF. - Rename the intermediate file to `audio_iamf.mp4` to be less ambiguous. - Fill in hash for expected output.
Fix hardcoded path in reframer-iamf test. (gpac#3567)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
original PR #59 merged to a local branch for buildbot
merge this one into master before merging gpac/gpac#3567