-
Notifications
You must be signed in to change notification settings - Fork 5
Fix datetime printing issue #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| #' @export | ||
| as_fmt_char.POSIXt <- function(x, ...) { | ||
| format(x, "%Y-%m-%d %H:%M:%S %Z") | ||
| x <- format(x, "%Y-%m-%d %H:%M:%S %Z") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think from memory this code exists (as opposed to just using as.character() ) to force the timestamp to be shown. Regular dates already have the NA conversion covered within the default as.character() handler but for some reason that was missed here
Code Coverage SummaryResults for commit: f9f0c06 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 13 suites 7s ⏱️ Results for commit f9f0c06. ♻️ This comment has been updated with latest results. |
|
Hi @gowerc , @kieranjmartin , when do you plan to merge and release the bug fix? The bug prevents displaying the differences in the admiralroche CI/CD jobs. |
kieranjmartin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor changes, just to expand the testing a little to ensure we have coverage
|
@kieranjmartin - Should be good for re-review |
|
@bundfussr - This is now on CRAN |
Great, thanks! |
Closes #132