refactor: use EVP_MAC in gost_tls12_additional_kdftree#522
Merged
chipitsine merged 2 commits intogost-engine:masterfrom Apr 2, 2026
Merged
refactor: use EVP_MAC in gost_tls12_additional_kdftree#522chipitsine merged 2 commits intogost-engine:masterfrom
chipitsine merged 2 commits intogost-engine:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the TLS 1.2 additional KDF tree implementation to stop using deprecated HMAC_* APIs and instead compute the per-iteration MAC using OpenSSL’s EVP_MAC interface, aligning the code with modern/provider-based OpenSSL usage.
Changes:
- Replaced
HMAC_CTXflow withEVP_MAC/EVP_MAC_CTXandOSSL_PARAM-driven digest selection. - Updated includes to support
EVP_MACconfiguration (core_names.h,params.h) and removedhmac.husage. - Added output-length verification for
EVP_MAC_final()results (out_len == 32).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve: #498