refactor(provider): adds signing to google maps provider requests geo…#122
Open
refactor(provider): adds signing to google maps provider requests geo…#122
Conversation
paliiuc
previously approved these changes
Jul 4, 2024
…code and reverse ref #FSMWO-1806
dobrea-v
force-pushed
the
feature/FSWMO-1806
branch
from
d0ede2b to
c45f0ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #FSMWO-1806
Summary
This changes implement signing of requests to Google Maps API's, so that the limit of 25k request is not hit, by extending Google Maps provider to accept secret key and then using it to generate the signature parameter for requests.
Context
Creating unsigned request to Google Maps API will hit rate limit of 25k requests per day. This can be bypassed be singing request on the internal service side.