build/biomejs #596
Merged
build/biomejs #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jpoehnelt
commented
Nov 25, 2025
jpoehnelt
commented
- build: switch to biomejs
- style: biome check --write
- style: biome check --write --unsafe
- style: manual fixes
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
Summary of ChangesHello @jpoehnelt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request marks a significant shift in the project's code quality tooling by migrating from ESLint to Biome. The change aims to standardize code formatting and linting, potentially offering performance benefits and a more integrated developer experience. This involved removing old configurations, adding new ones, and applying automated formatting across a wide range of JavaScript and TypeScript files. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the project's linting and formatting from ESLint to BiomeJS. This is a significant and welcome change for standardizing code style. The changes mostly consist of applying Biome's auto-formatting across the codebase, removing old ESLint configurations, and updating the project dependencies. While reviewing, I found a few critical issues related to logic and potential runtime errors that were either pre-existing or surfaced by the refactoring. My comments focus on these to ensure the code's correctness and robustness.
Member
Author
|
/gemini summary |
Contributor
Summary of ChangesThis pull request fundamentally refactors the project's code quality infrastructure by replacing ESLint with Biome. The primary goal is to establish a unified and efficient system for linting and formatting, ensuring a consistent code style throughout the repository. This change impacts a significant portion of the JavaScript and TypeScript files, bringing them in line with the new automated styling rules and improving overall code maintainability. Highlights
Changelog
Ignored Files
Activity
|
… HTML stripping, and update Gemini API parameter name.
Member
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request marks a significant improvement by migrating the project from ESLint to BiomeJS for code linting and formatting. The changes are extensive but well-executed, resulting in more consistent and modern code style across the entire repository. I appreciate the numerous small refactorings, such as using const over let, adopting template literals, and fixing a potential runtime error when parsing URLs. I found one minor issue regarding undeclared variables that was likely missed during the automated formatting. Overall, this is a great step forward for the project's maintainability.
Member
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request successfully migrates the project's linting and formatting from ESLint to Biome. The changes are extensive, touching many files with stylistic and formatting updates, which will improve code consistency. I've noted a couple of significant improvements that also fix potential bugs, such as more robust error handling and parsing. Overall, this is a solid upgrade to the project's tooling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.