Skip to content

Conversation

@JoachimAmoah
Copy link

@JoachimAmoah JoachimAmoah commented Dec 4, 2025

Implements handlers for the following events:
onMapDrag
onMapDragEnd

Adds the following controls:
coordinateForPoint
pointForCoordinate
fitBounds
getBounds

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation
  • I added new tests to check the change I am making
  • All existing and new tests are passing.

@JoachimAmoah
Copy link
Author

JoachimAmoah commented Dec 4, 2025

@jokerttu @caio1985 HI 👋 Can you take a look 🙏 . I have another upcoming PR to add a declarative marker <MarkerView /> to allow passing any react node to use as the marker via setIconView, it's working :) and I can't wait to follow-up after this gets merged.

@jokerttu jokerttu self-requested a review December 5, 2025 13:27
@jokerttu jokerttu self-assigned this Dec 5, 2025
@jokerttu
Copy link
Contributor

jokerttu commented Dec 5, 2025

Hi @JoachimAmoah, thank you for your contribution!
We’ll add this to our review queue and look into it soon.

@jokerttu
Copy link
Contributor

jokerttu commented Dec 15, 2025

@JoachimAmoah Sorry, we have not had time to go through this yet.

We are moving to a new architecture soon on version 0.13.0, and this changes how we communicate with the native code and will affect this behavior as well.

You also mentioned that you have made a feature that allows creating views with setIconView, clearly pointing to support for Advanced Markers.

Support for Advanced Markers, as well as moving from control methods to controlling map objects via components, is on the roadmap as well. We are interested to see your approach.

@JoachimAmoah
Copy link
Author

@jokerttu My team initially wanted to wait for the Fabric changes when we saw the draft but after we realized the features were looking for wasn't much we created this PR. The full features we want to add, including AdvancedMarker is here on our fork.

Since porting to Fabric only changes how native-JS communication is done, won't it be easier to at least add this PR in a minor release before 0.13.0, especially if the bulk of the code/logic remains the same?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants