Skip to content

fix: re-expose public iOS header files #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jokerttu merged 2 commits into from
Dec 1, 2025
Merged

fix: re-expose public iOS header files #509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
608da7c
fix: re-expose public header files for driver SDK
jokerttu Nov 28, 2025
be24fac
fix: re-expose public header files for driver SDK
jokerttu Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion example/ios/SampleApp/CarSceneDelegate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/
#import <CarPlay/CarPlay.h>
#import "BaseCarSceneDelegate.h"
#import <ReactNativeGoogleMapsNavigation/BaseCarSceneDelegate.h>

@interface CarSceneDelegate : BaseCarSceneDelegate
@end
4 changes: 2 additions & 2 deletions example/ios/SampleApp/CarSceneDelegate.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
#import "CarSceneDelegate.h"
#import <CarPlay/CarPlay.h>
#import <Foundation/Foundation.h>
#import "NavAutoModule.h"
#import "NavModule.h"
#import <ReactNativeGoogleMapsNavigation/NavAutoModule.h>
#import <ReactNativeGoogleMapsNavigation/NavModule.h>

@implementation CarSceneDelegate

Expand Down
1 change: 0 additions & 1 deletion example/ios/SampleApp/PhoneSceneDelegate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
*/
#import <React/RCTRootView.h>
#import <UIKit/UIKit.h>
#import "AppDelegateCarPlay.h"

@interface PhoneSceneDelegate : UIResponder <UIWindowSceneDelegate>

Expand Down
7 changes: 6 additions & 1 deletion ios/react-native-navigation-sdk/BaseCarSceneDelegate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@
* limitations under the License.
*/
#import <CarPlay/CarPlay.h>
#import "NavViewController.h"

NS_ASSUME_NONNULL_BEGIN

@class NavViewController; // forward declaration

@interface BaseCarSceneDelegate
: UIResponder <CPTemplateApplicationSceneDelegate, CPMapTemplateDelegate>
Expand All @@ -29,3 +32,5 @@
- (CPMapTemplate *)getTemplate;

@end

NS_ASSUME_NONNULL_END
1 change: 1 addition & 0 deletions ios/react-native-navigation-sdk/BaseCarSceneDelegate.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#import "CustomTypes.h"
#import "NavAutoModule.h"
#import "NavModule.h"
#import "NavViewController.h"

@implementation BaseCarSceneDelegate

Expand Down
3 changes: 2 additions & 1 deletion ios/react-native-navigation-sdk/NavAutoModule.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,11 @@
* limitations under the License.
*/
#import <React/RCTBridgeModule.h>
#import "NavViewController.h"

NS_ASSUME_NONNULL_BEGIN

@class NavViewController; // forward declaration

@interface NavAutoModule : NSObject <RCTBridgeModule>
@property(nonatomic, strong, nullable) NavViewController *viewController;

Expand Down
1 change: 1 addition & 0 deletions ios/react-native-navigation-sdk/NavAutoModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

#import "NavAutoModule.h"
#import "NavAutoEventDispatcher.h"
#import "NavViewController.h"

@implementation NavAutoModule

Expand Down
9 changes: 8 additions & 1 deletion react-native-navigation-sdk.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ package = JSON.parse(File.read(File.join(__dir__, "package.json")))

Pod::Spec.new do |s|
s.name = "react-native-navigation-sdk"
s.header_dir = "ReactNativeGoogleMapsNavigation"
s.module_name = "ReactNativeGoogleMapsNavigation"
s.version = package["version"]
s.summary = package["description"]
s.homepage = package["homepage"]
Expand All @@ -30,7 +32,12 @@ Pod::Spec.new do |s|
s.source = { :git => "https://github.com/googlemaps/react-native-navigation-sdk.git", :tag => "#{s.version}" }

s.source_files = "ios/**/*.{h,m,mm,cpp}"
s.private_header_files = "ios/**/*.h"
s.public_header_files = [
"ios/react-native-navigation-sdk/BaseCarSceneDelegate.h",
"ios/react-native-navigation-sdk/INavigationCallback.h",
"ios/react-native-navigation-sdk/NavAutoModule.h",
"ios/react-native-navigation-sdk/NavModule.h",
]

s.dependency "React-Core"
s.dependency "GoogleNavigation", "10.6.0"
Expand Down
Loading