Skip to content

add a rudimentary check for mismatched snippet tags in final output #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willum070 merged 2 commits into from
May 8, 2026
+10 −1
Merged

add a rudimentary check for mismatched snippet tags in final output #1425

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1456f6a
add a rudimentary check for mismatched snippet tags in final output
chrisjshull May 8, 2026
d452b19
Merge branch 'main' into pretty8
willum070 May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion samples/build-single.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,13 +175,22 @@ if ls *.js; then # Note: DNE for react builds
npx prettier -w *.js --ignore-path /dev/null # --ignore-path /dev/null forces enablement
fi

# one more check (this one needs typings stripped to work)
# post-build checks:
set +e

start_snippet_ct=$(grep "\[START " "${common_recursive_grep_options[@]}" --include=*.js | wc -l)
end_snippet_ct=$(grep "\[END " "${common_recursive_grep_options[@]}" --include=*.js | wc -l)
if [[ $start_snippet_ct -ne $end_snippet_ct ]]; then
echo "Mismatched snippet tags in final output (may have been stripped by TSC)."
exit 1
fi

grep "google\.maps\." "${common_recursive_grep_options[@]}" --include=*.js | grep -v "google.maps.importLibrary" | grep -v -E '^[-_./a-z0-9]+:\s*//'
if [[ $? -eq 0 ]]; then
echo "Using google.maps namespace for something other than google.maps.importLibrary()."
exit 1
fi

set -e

bash ../jsfiddle.sh "$NAME"
Expand Down
Loading