Skip to content

feat: Refactors the 3d-camera-boundary sample to latest standards.#1415

Open
willum070 wants to merge 1 commit intomainfrom
refactor-3d-camera-boundary
Open

feat: Refactors the 3d-camera-boundary sample to latest standards.#1415
willum070 wants to merge 1 commit intomainfrom
refactor-3d-camera-boundary

Conversation

@willum070
Copy link
Copy Markdown
Collaborator

This PR does the following things:

  • Refactors the 3d-camera-boundary sample to latest standards.
  • Replaces the <div id="map"></div> element in index.html with a <gmp-map-3d> web component.
  • Removes unused CSS rules.
  • Bumps copyrights to 2026.
  • Removes empty dependencies section from package.json.

Key changes:

Migration to web component:

  • Replaces the <div id="map"></div> element in index.html with a <gmp-map-3d> web component, setting its initial center, tilt, mode, and gesture handling via attributes. (samples/3d-camera-boundary/index.html samples/3d-camera-boundary/index.htmlL22-R28)
  • Updates index.ts to select the gmp-map-3d element and set its bounds property directly, removing the previous instantiation of Map3DElement in JavaScript. (samples/3d-camera-boundary/index.ts samples/3d-camera-boundary/index.tsL3-R19)

Code and dependency cleanup:

Other updates:

  • Updates copyright years from 2025 to 2026 in all files. (samples/3d-camera-boundary/index.html [1] samples/3d-camera-boundary/index.ts [2] samples/3d-camera-boundary/style.css [3]

@willum070 willum070 requested a review from oppenheimera May 7, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant