Open
Conversation
wangela
requested changes
Jan 10, 2023
Contributor
wangela
left a comment
There was a problem hiding this comment.
Thank you for this pull request!
- All the files under /src/gms/java/com/example/mapdemo and /src/gms/res should be moved to /src/main, not deleted.
- Recommend leaving ApiDemos/java/gradle/wrapper/gradle-wrapper.properties unchanged as Gradle dependencies should be updated in a separate PR to keep the scope of this PR tidy.
- Since new commits have been merged since this PR, please sync your fork and resolve any merge conflicts
| @@ -1,5 +1,6 @@ | |||
| .gradle | |||
| /local.properties | |||
| /local.defaults.properties | |||
Contributor
There was a problem hiding this comment.
This should not be gitignored
| // V3 | ||
| v3Implementation 'com.google.android.libraries.maps:maps:3.1.0-beta' | ||
|
|
||
| // Tests |
Contributor
There was a problem hiding this comment.
We should keep the tests lines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕