fix: tests.system.test_database_api: test_table_not_found failed #1484

[bhatt4982]

add not_postgres fixture to test_table_not_found system test

Issue #1484: tests.system.test_database_api: test_table_not_found failed

Flaky Test: tests.system.test_database_api: test_table_not_found

system-3-14-protobuf_implementation-python-database_dialect-postgresql
...
create_statement: "CREATE DATABASE tbl_not_...L,\n    Field1  STRING(36) NOT NULL\n) PRIMARY KEY (Id)"
...
extra_statements: "CREATE INDEX IDX ON NotMyTable (Field1)"
...
google.api_core.exceptions.Unauthenticated: 401 Request had invalid authentication credentials. Expected OAuth 2 access token, login cookie or other valid authentication credential.

This test is not required in postgresql env - statements are in GoogleSQL. Disabling the test for now, will check if flakiness improves...

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

• Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
• Ensure the tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)

Fixes #1484 🦕

[gemini-code-assist]

Summary of Changes

Hello @bhatt4982, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a system test failure by introducing an environment-specific fixture to the test_table_not_found function. The change prevents the test from executing in PostgreSQL environments, where it was not intended to run, thus improving the stability and reliability of the test suite.

Highlights

• Test Fix: Added the not_postgres fixture to the test_table_not_found system test. This ensures the test is skipped in PostgreSQL environments, resolving a reported failure.

Changelog

• tests/system/test_database_api.py
  • Added not_postgres fixture to the test_table_not_found function signature.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a failing system test, test_table_not_found, by adding the not_postgres fixture. This ensures the test is skipped when running against a PostgreSQL dialect database, as the test contains DDL statements specific to Google Standard SQL that are not compatible with PostgreSQL. The change is appropriate and resolves the issue.