Skip to content

Conversation

@skuruppu
Copy link
Contributor

@skuruppu skuruppu commented Jan 9, 2026

Snippet shows how to set the read lock mode at the client-level and how to override the option at the transaction-level.

Snippet shows how to set the read lock mode at the client-level and how
to override the option at the transaction-level.
@skuruppu skuruppu requested review from a team as code owners January 9, 2026 00:35
@skuruppu skuruppu requested a review from parthea January 9, 2026 00:35
@snippet-bot
Copy link

snippet-bot bot commented Jan 9, 2026

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jan 9, 2026
@product-auto-label product-auto-label bot added api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. labels Jan 9, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @skuruppu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new code example for Google Cloud Spanner, focusing on the configuration of read lock modes within read-write transactions. The added snippet provides clear guidance on how to apply read lock settings both globally at the client level and specifically for individual transactions, enhancing flexibility for developers managing concurrency. This change improves the documentation and usability of Spanner's transaction options.

Highlights

  • New Snippet for Read Lock Mode: A new Python snippet, read_lock_mode_options, has been added to demonstrate how to configure read lock modes for Google Cloud Spanner read-write transactions.
  • Client-Level Configuration: The snippet illustrates setting a default read lock mode (e.g., OPTIMISTIC) at the Spanner client level, which applies to all subsequent read-write transactions.
  • Transaction-Level Override: It also shows how to override the client-level read lock mode with a different mode (e.g., PESSIMISTIC) for a specific transaction, providing granular control.
  • Snippet Integration and Testing: The new snippet has been integrated into the command-line interface for snippets.py and includes a corresponding unit test in snippets_test.py to ensure its functionality.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new snippet to demonstrate setting the read lock mode for Spanner transactions, both at the client and transaction level. The changes include the new snippet function, its command-line integration, and a corresponding unit test. The implementation is sound, but there's a minor style issue regarding the placement of the docstring in the new function, which I've commented on.

Comment on lines +3239 to +3243
from google.cloud.spanner_v1 import TransactionOptions, DefaultTransactionOptions

"""
Shows how to run a Read Write transaction with read lock mode options.
"""

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

According to PEP 257, a function's docstring should be the first statement within the function body. To adhere to this convention, please move the import statement to be after the docstring.

Suggested change
from google.cloud.spanner_v1 import TransactionOptions, DefaultTransactionOptions
"""
Shows how to run a Read Write transaction with read lock mode options.
"""
"""
Shows how to run a Read Write transaction with read lock mode options.
"""
from google.cloud.spanner_v1 import TransactionOptions, DefaultTransactionOptions
References
  1. A docstring is a string literal that occurs as the first statement in a module, function, class, or method definition. Such a docstring becomes the doc special attribute of that object. (link)


@pytest.mark.dependency(depends=["insert_data"])
def test_isolated_level_options(capsys, instance_id, sample_database):
def test_isolation_level_options(capsys, instance_id, sample_database):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Good catch fixing the typo in the test function name from test_isolated_level_options to test_isolation_level_options. This improves consistency with the function it's testing (isolation_level_options).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants