-
Notifications
You must be signed in to change notification settings - Fork 99
docs(spanner): snippet for setting read lock mode #1473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Snippet shows how to set the read lock mode at the client-level and how to override the option at the transaction-level.
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @skuruppu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new code example for Google Cloud Spanner, focusing on the configuration of read lock modes within read-write transactions. The added snippet provides clear guidance on how to apply read lock settings both globally at the client level and specifically for individual transactions, enhancing flexibility for developers managing concurrency. This change improves the documentation and usability of Spanner's transaction options. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new snippet to demonstrate setting the read lock mode for Spanner transactions, both at the client and transaction level. The changes include the new snippet function, its command-line integration, and a corresponding unit test. The implementation is sound, but there's a minor style issue regarding the placement of the docstring in the new function, which I've commented on.
| from google.cloud.spanner_v1 import TransactionOptions, DefaultTransactionOptions | ||
|
|
||
| """ | ||
| Shows how to run a Read Write transaction with read lock mode options. | ||
| """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to PEP 257, a function's docstring should be the first statement within the function body. To adhere to this convention, please move the import statement to be after the docstring.
| from google.cloud.spanner_v1 import TransactionOptions, DefaultTransactionOptions | |
| """ | |
| Shows how to run a Read Write transaction with read lock mode options. | |
| """ | |
| """ | |
| Shows how to run a Read Write transaction with read lock mode options. | |
| """ | |
| from google.cloud.spanner_v1 import TransactionOptions, DefaultTransactionOptions | |
References
- A docstring is a string literal that occurs as the first statement in a module, function, class, or method definition. Such a docstring becomes the doc special attribute of that object. (link)
|
|
||
| @pytest.mark.dependency(depends=["insert_data"]) | ||
| def test_isolated_level_options(capsys, instance_id, sample_database): | ||
| def test_isolation_level_options(capsys, instance_id, sample_database): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snippet shows how to set the read lock mode at the client-level and how to override the option at the transaction-level.