Skip to content

test: microgen - adds tests to confirm attribute extraction from classes #2315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chalmerlowe merged 4 commits into from
Oct 6, 2025
Merged

test: microgen - adds tests to confirm attribute extraction from classes #2315

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d05aa9b
test: adds tests to confirm attribute extraction from classes
chalmerlowe Oct 6, 2025
e92c397
Update scripts/microgenerator/tests/unit/test_generate_analyzer.py
chalmerlowe Oct 6, 2025
4ef99b9
adds docstring
chalmerlowe Oct 6, 2025
e7e257e
Merge branch 'autogen' into test/extraction-of-class-and-instance-att…
chalmerlowe Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
172 changes: 172 additions & 0 deletions scripts/microgenerator/tests/unit/test_generate_analyzer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,3 +87,175 @@ def test_import_extraction(self, code_snippet, expected_imports):
expected = sorted(expected_imports)

assert extracted == expected


# --- Tests CodeAnalyzer handling of Attributes ---


class TestCodeAnalyzerAttributes:

@pytest.mark.parametrize(
"code_snippet, expected_structure",
[
pytest.param(
"""
class MyClass:
CLASS_VAR = 123
""",
Copy link
Contributor

@daniel-sanche daniel-sanche Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this would probably be more readable using parentheses for the multiline string, to avoid breaking indentation:

            pytest.param(
                (
                    "class MyClass:"
                    "    CLASS_VAR = 123",
                ),
                [
                    {
                        "class_name": "MyClass",
                        "methods": [],
                        "attributes": [{"name": "CLASS_VAR", "type": None}],
                    }
                ],
                id="class_var_assign",
            ),

Copy link
Contributor

@daniel-sanche daniel-sanche Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might also be easier to read/scale if test cases are stored in a yaml file. We did something similar for bigtable here

Copy link
Collaborator Author

@chalmerlowe chalmerlowe Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea. I will make a note of this. For now, the priority is to get a complete set of working unit tests, so not gonna jump on this refactor right away.

[
{
"class_name": "MyClass",
"methods": [],
"attributes": [{"name": "CLASS_VAR", "type": None}],
}
],
id="class_var_assign",
),
pytest.param(
"""
class MyClass:
class_var: int = 456
""",
[
{
"class_name": "MyClass",
"methods": [],
"attributes": [{"name": "class_var", "type": "int"}],
}
],
id="class_var_annassign",
),
pytest.param(
"""
class MyClass:
class_var: int
""",
[
{
"class_name": "MyClass",
"methods": [],
"attributes": [{"name": "class_var", "type": "int"}],
}
],
id="class_var_annassign_no_value",
),
pytest.param(
"""
class MyClass:
def __init__(self):
self.instance_var = 789
""",
[
{
"class_name": "MyClass",
"methods": [
{
"method_name": "__init__",
"args": [{"name": "self", "type": None}],
"return_type": None,
}
],
"attributes": [{"name": "instance_var", "type": None}],
}
],
id="instance_var_assign",
),
pytest.param(
"""
class MyClass:
def __init__(self):
self.instance_var: str = 'hello'
""",
[
{
"class_name": "MyClass",
"methods": [
{
"method_name": "__init__",
"args": [{"name": "self", "type": None}],
"return_type": None,
}
],
"attributes": [{"name": "instance_var", "type": "str"}],
}
],
id="instance_var_annassign",
),
pytest.param(
"""
class MyClass:
def __init__(self):
self.instance_var: str
""",
[
{
"class_name": "MyClass",
"methods": [
{
"method_name": "__init__",
"args": [{"name": "self", "type": None}],
"return_type": None,
}
],
"attributes": [{"name": "instance_var", "type": "str"}],
}
],
id="instance_var_annassign_no_value",
),
pytest.param(
"""
class MyClass:
VAR_A = 1
var_b: int = 2
def __init__(self):
self.var_c = 3
self.var_d: float = 4.0
""",
[
{
"class_name": "MyClass",
"methods": [
{
"method_name": "__init__",
"args": [{"name": "self", "type": None}],
"return_type": None,
}
],
"attributes": [
{"name": "VAR_A", "type": None},
{"name": "var_b", "type": "int"},
{"name": "var_c", "type": None},
{"name": "var_d", "type": "float"},
],
}
],
id="mixed_attributes",
),
pytest.param(
"a = 123 # Module level",
[],
id="module_level_assign",
),
pytest.param(
"b: int = 456 # Module level",
[],
id="module_level_annassign",
),
],
)
def test_attribute_extraction(self, code_snippet: str, expected_structure: list):
"""Tests the extraction of class and instance attributes."""
analyzer = CodeAnalyzer()
tree = ast.parse(code_snippet)
analyzer.visit(tree)

extracted = analyzer.structure
# Normalize attributes for order-independent comparison
for item in extracted:
if "attributes" in item:
item["attributes"].sort(key=lambda x: x["name"])
for item in expected_structure:
if "attributes" in item:
item["attributes"].sort(key=lambda x: x["name"])

assert extracted == expected_structure
Loading