feat: add bigframe.bigquery.load_data function #2426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
shuoweil
reviewed
Feb 2, 2026
|
|
||
| @mock.patch("bigframes.bigquery._operations.io._get_table_metadata") | ||
| def test_load_data(get_table_metadata_mock, mock_session): | ||
| bigframes.bigquery._operations.io.load_data( |
Contributor
There was a problem hiding this comment.
I suggest adding a doctest to each test case to better illustrate the test's purpose.
Contributor
Author
There was a problem hiding this comment.
You mean a comment for the tests or doctests to the function?
If the former case. These tests are simple and self-explanatory.
Contributor
Author
There was a problem hiding this comment.
The web link in the doc illustrates what the function does. https://docs.cloud.google.com/bigquery/docs/reference/standard-sql/load-statements
For this DDL, a table will be created. In doctest it can't clean that table... Which makes doctest impossible.
Generally doctests have problems, usually causing failures and hard to debug. We may want to find better ways.
GarrettWu
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
GarrettWu
added
the
kokoro:force-run
bigframes-bot
removed
the
kokoro:force-run
shuoweil
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕