test: Fix penguins_linear_model_w_global_explain fixture#2327
Merged
TrevorBergeron merged 2 commits intomainfrom Dec 12, 2025
Merged
test: Fix penguins_linear_model_w_global_explain fixture#2327TrevorBergeron merged 2 commits intomainfrom
TrevorBergeron merged 2 commits intomainfrom
Conversation
product-auto-label
bot
added
size: s
TrevorBergeron
force-pushed
the
fixture_out_of_place
branch
from
82a0c5f to
0662742
Compare
product-auto-label
bot
added
size: m
tswast
reviewed
Dec 12, 2025
Comment on lines
23
to
29
| @pytest.fixture(scope="function") | ||
| def penguins_linear_model_w_global_explain( | ||
| penguins_bqml_linear_model: core.BqmlModel, | ||
| ) -> bigframes.ml.linear_model.LinearRegression: | ||
| bf_model = bigframes.ml.linear_model.LinearRegression(enable_global_explain=True) | ||
| bf_model._bqml_model = penguins_bqml_linear_model | ||
| return bf_model |
Collaborator
There was a problem hiding this comment.
Since this is defined in conftest.py, this shouldn't be required, right?
Contributor
Author
There was a problem hiding this comment.
yeah, should be redundant. removed in new revision
tswast
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕