feat: support Series.dot on a DataFrame input#230
Closed
Conversation
product-auto-label
bot
added
size: s
Genesis929
previously approved these changes
Nov 27, 2023
product-auto-label
bot
added
size: m
TrevorBergeron
requested changes
Nov 28, 2023
bigframes/series.py
Outdated
Comment on lines
684
to
691
| return Series( | ||
| [ | ||
| pandas.NA if other[col].isna().any() else (self * other[col]).sum() | ||
| for col in other.columns | ||
| ], | ||
| index=other.columns, | ||
| name=self.name, | ||
| ) |
Contributor
There was a problem hiding this comment.
This will perform several queries, as each aggregate .any() operation initiates a query. I think we can do this more efficiently.
Contributor
Author
There was a problem hiding this comment.
Sent an optimization, PTAL. It doesn't apply to multi-index yet due to b/313747368, left a TODO.
Contributor
Author
There was a problem hiding this comment.
in the latest version only the multi-level columns operand implementation is inefficient (which should be a less common use case). Hope we can accept it for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes internal issue 312559139 🦕