Fix: Anywidget Table Pagination for Small DataFrames & Improve Displa…#2287
Merged
Fix: Anywidget Table Pagination for Small DataFrames & Improve Displa…#2287
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
product-auto-label
bot
added
size: m
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses a pagination display bug in the
anywidgettable where a small DataFrame (e.g., 5 rows) would incorrectly show "Page 1 of 5" instead of "Page 1 of 1".table_widget.jspagination logic: Corrected the JavaScript to accurately calculate total pages, ensuring "Page 1 of 1" is displayed for datasets smaller than the page size.test_anywidget.pyby improving thetest_widget_with_few_rows_should_have_only_one_pagetest. This test now explicitly asserts the correctrow_countand verifies that page navigation is correctly clamped to the first page, thus confirming the backend conditions for the "Page 1 of 1" frontend display.Fixes #<issue_number_goes_here> 🦕