Refactor: Remove duplicate _has_json_arrow_type from loader.py#2221
Merged
Refactor: Remove duplicate _has_json_arrow_type from loader.py#2221
Conversation
Collaborator
|
Presubmit failures: These are all blob or ai related. I'll see if this is a recurring issue and file an issue to make these more robust. |
chelsea-lin
approved these changes
Nov 3, 2025
Contributor
Author
Thanks Tim. I have a feeling it is the bigquery change brings in this failure. I am the oncall this week. I am investigating for the it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR eliminates a redundant function, _has_json_arrow_type, from bigframes/session/loader.py. The logic of this function is identical to bigframes.dtypes.contains_db_dtypes_json_arrow_type.
The call to the removed function within _validate_dtype_can_load has been updated to utilize the existing bigframes.dtypes.contains_db_dtypes_json_arrow_type.
This refactoring improves code maintainability and reduces duplication by centralizing the logic for checking JSON arrow types.