feat: make all and any compatible with integer columns on Polars session#2154
Merged
feat: make all and any compatible with integer columns on Polars session#2154
all and any compatible with integer columns on Polars session#2154Conversation
…ples Also, fixes several constructors that didn't take a session for compatibility with multi-session applications.
… tswast-doctest-boilerplate
This reverts commit 765b678.
product-auto-label
bot
added
size: xl
tswast
commented
Oct 9, 2025
Collaborator
Author
There was a problem hiding this comment.
Coverage failure. I think I should add # pragma: no cover to the currently skipped tests.
Collaborator
Author
There was a problem hiding this comment.
Actually, I think it's the new methods on Session. Created #2157 which splits out that part and actually fixes a bug in the to_timedelta implementation.
Collaborator
Author
There was a problem hiding this comment.
Note: this file is a nearly exact copy of the tests/system/small/test_series.py file with additional fixtures for unit testing.
Collaborator
Author
|
Failures appear unrelated. e2e failure samples failure |
TrevorBergeron
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕